Disallow Adding, Importing, Editing, and Deleting a Feature Flag for Users with the 'Reader' Role #2002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Users with the 'Reader' Role
zackcl
requested review from
VivekFitkariwala,
bcb37,
ppratikcr7,
RidhamShah,
Yagnik56 and
danoswaltCL
|
It seems that it's quite challenging to make the slide toggles disabled but retain their colored appearance. We have two potential approaches:
I've attempted both approaches, and they both present significant difficulties. For now, I've simply set the "disabled" attribute to true to make the toggles unresponsive. I can revisit this issue later, but if anyone has a robust solution, please let me know. 
|
Yagnik56
previously requested changes
Oct 3, 2024
...ions-section-card/feature-flag-exclusions-table/feature-flag-exclusions-table.component.html
Outdated
Show resolved
Hide resolved
...ent/feature-flag-exclusions-section-card/feature-flag-exclusions-section-card.component.html
Show resolved
Hide resolved
ppratikcr7
requested changes
Oct 3, 2024
There was a problem hiding this comment.
@zackcl So, after the last commit, the exclusion list edit and and delete action buttons are disabled for admin role and enabled for reader role. Can you please check this.
ppratikcr7
approved these changes
Oct 3, 2024
This was referenced Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1998
This PR resolves the issue but the CSS styles for the disabled slide toggles and edit/remove buttons might need to be improved, because currently they are simply greyed out.